| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] pg_regress breaks on msys |
| Date: | 2006-07-28 20:00:02 |
| Message-ID: | 200607282000.k6SK02x04643@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I checked on MinGW and system() just returns the value returned by the
> > application. There isn't any special two-values-in-one layering like is
> > done on Unix for wait() and the return value from system(). It seems if
> > the child dies from a signal, the parent dies too, at least in my C
> > tests.
>
> The cases that I think we most need to defend against are
>
> (A) diff program not found
>
> (B) diff fails to read one of the input files
>
> I think your proposal handles case B, because diff should return exit
> code 2 which we will detect, but what happens in case A? Please test it.
It returns 1.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dann Corbit | 2006-07-28 20:02:32 | Re: On-disk bitmap index patch |
| Previous Message | Tom Lane | 2006-07-28 19:59:20 | Re: [HACKERS] pg_regress breaks on msys |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-07-28 20:04:00 | Re: [HACKERS] pg_regress breaks on msys |
| Previous Message | Tom Lane | 2006-07-28 19:59:20 | Re: [HACKERS] pg_regress breaks on msys |