From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] pg_regress breaks on msys |
Date: | 2006-07-28 19:59:20 |
Message-ID: | 562.1154116760@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I checked on MinGW and system() just returns the value returned by the
> application. There isn't any special two-values-in-one layering like is
> done on Unix for wait() and the return value from system(). It seems if
> the child dies from a signal, the parent dies too, at least in my C
> tests.
The cases that I think we most need to defend against are
(A) diff program not found
(B) diff fails to read one of the input files
I think your proposal handles case B, because diff should return exit
code 2 which we will detect, but what happens in case A? Please test it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-07-28 20:00:02 | Re: [HACKERS] pg_regress breaks on msys |
Previous Message | Bruce Momjian | 2006-07-28 19:54:50 | Re: [HACKERS] 8.2 features? |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-07-28 20:00:02 | Re: [HACKERS] pg_regress breaks on msys |
Previous Message | Bruce Momjian | 2006-07-28 19:54:50 | Re: [HACKERS] 8.2 features? |