Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pg_regress breaks on msys

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_regress breaks on msys
Date: 2006-07-28 20:04:00
Message-ID: 200607282004.k6SK40n06029@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > I checked on MinGW and system() just returns the value returned by the
> > > application.  There isn't any special two-values-in-one layering like is
> > > done on Unix for wait() and the return value from system().  It seems if
> > > the child dies from a signal, the parent dies too, at least in my C
> > > tests.
> > 
> > The cases that I think we most need to defend against are
> > 
> > (A) diff program not found
> > 
> > (B) diff fails to read one of the input files
> > 
> > I think your proposal handles case B, because diff should return exit
> > code 2 which we will detect, but what happens in case A?  Please test it.
> 
> It returns 1.

In summary, on MinGW, files differ or 'diff' not found, returns 1.  If
one of the files to be compared does not exist, it returns 2.  And of
course, if the files are the same, it returns zero.

I assume MSVC builds will have problem with the diff call.

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2006-07-28 20:08:24
Subject: Re: [HACKERS] pg_regress breaks on msys
Previous:From: Dann CorbitDate: 2006-07-28 20:02:32
Subject: Re: On-disk bitmap index patch

pgsql-patches by date

Next:From: Tom LaneDate: 2006-07-28 20:08:24
Subject: Re: [HACKERS] pg_regress breaks on msys
Previous:From: Bruce MomjianDate: 2006-07-28 20:00:02
Subject: Re: [HACKERS] pg_regress breaks on msys

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group