Another pgindent gripe

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Another pgindent gripe
Date: 2005-11-07 12:19:40
Message-ID: 20051107121940.GB12167@surnet.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I have another gripe regarding pgindent. Why does it change indenting
of function declarations? An example is at the end. I think it may be
thinking that declarations should be aligned using 8-spaces tabs. Can
this be corrected?

It annoyed me just now, because I'm adjusting my vacuum patch and lots
of conflicts appeared because it chose to change the spacing. A
pointless change for an automatic tool to make, if I must add, and one
that adds gratuituous work for the human wanting to do some real work.

Index: vacuum.c
===================================================================
RCS file: /home/alvherre/cvs/pgsql/src/backend/commands/vacuum.c,v
retrieving revision 1.316
retrieving revision 1.317
diff -c -r1.316 -r1.317
*** vacuum.c 3 Oct 2005 22:52:21 -0000 1.316
--- vacuum.c 15 Oct 2005 02:49:16 -0000 1.317
***************
*** 198,204 ****

/* non-export function prototypes */
static List *get_rel_oids(List *relids, const RangeVar *vacrel,
! const char *stmttype);
static void vac_update_dbstats(Oid dbid,
TransactionId vacuumXID,
TransactionId frozenXID);
--- 198,204 ----

/* non-export function prototypes */
static List *get_rel_oids(List *relids, const RangeVar *vacrel,
! const char *stmttype);
static void vac_update_dbstats(Oid dbid,
TransactionId vacuumXID,
TransactionId frozenXID);

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2005-11-07 13:13:13 Re: Problems with index-scan on regexp in 8.1
Previous Message Michael Paesold 2005-11-07 10:21:50 Re: Interval aggregate regression failure (expected seems