From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: statement_timeout logging |
Date: | 2005-09-21 19:10:04 |
Message-ID: | 200509211910.j8LJA4S14913@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Simon Riggs wrote:
> On Mon, 2005-09-19 at 13:21 -0400, Bruce Momjian wrote:
>
> > OK. I tested it and it actually works
>
> Gosh, that says a lot about my code quality. I will strive to improve
> from "actually works" to "works as expected" for future patches.
>
> > and I added documentation
> > suggesting its usage.
>
> > ! If <varname>log_min_error_statement</> is set to
> > ! <literal>ERROR</> or lower, the statement that timed out will also be
> >
>
> Might I suggest "Even if" rather than "if"?
I don't see why "even if" makes sense here. There is no expectation
that log_min_error_statement wouldn't work as documented. I am more
suggesting that it is a nifity way to use the option.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-09-21 19:39:11 | Re: Table Partitioning is in 8.1 |
Previous Message | Martijn van Oosterhout | 2005-09-21 19:06:24 | Re: Table Partitioning is in 8.1 |