errmsg("... because ...")

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: errmsg("... because ...")
Date: 2004-12-10 18:44:08
Message-ID: 20041210184408.GA7357@surnet.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hackers,

There are a bunch of error messages saying something like

"cannot foo because bar"

For example,

errmsg("cannot assign to field \"%s\" of column \"%s\" because its type %s is not a composite type")

What do you think of changing those to use errdetail in addition to
errmsg? So this particular example would become something like

errmsg("cannot assign to field \"%s\" of column \"%s\"),
errdetail("Its type %s is not a composite type.")

There are some of them that should probably be left alone, like

errmsg("terminating connection because of crash of another server process")

I see around a dozen messages in the backend that could be changed like
this.

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"La gente vulgar solo piensa en pasar el tiempo;
el que tiene talento, en aprovecharlo"

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Browne 2004-12-10 19:12:36 Re: V8 Beta 5 on AIX
Previous Message Patrick B Kelly 2004-12-10 18:30:26 Re: Call for port reports