Re: more dirmod CYGWIN

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Reini Urban <rurban(at)x-ray(dot)at>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: more dirmod CYGWIN
Date: 2004-10-08 00:38:57
Message-ID: 200410080038.i980cvo04244@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Reini Urban wrote:
> Bruce Momjian schrieb:
> > I have applied all parts of your patch now.
>
> Thanks. Core builds and works fine now. (plperl IPC problems aside)
>
> But there's are still some more minor SHLIB glitches,
> which only affects contrib, because -lpgport is missing for various dll's.
>

FYI, I think we fixed plperl for Win32 today.

> SHLIB_LINK doesn't contain the libs only the paths, because they are
> filtered out somewhere.
> But first I want to find the real cause of the problem.
> Maybe LIB is just missing a -lpgport.

Would you please post the link command and error that is failing below:

---------------------------------------------------------------------------

>
>
> $ diff -bu src/Makefile.shlib.orig src/Makefile.shlib
> --- src/Makefile.shlib.orig 2004-09-03 00:06:43.000000000 +0100
> +++ src/Makefile.shlib 2004-09-10 17:12:18.528655500 +0100
> @@ -216,6 +216,7 @@
>
> ifeq ($(PORTNAME), cygwin)
> shlib = $(NAME)$(DLSUFFIX)
> + SHLIB_LINK += -lpgport
> endif
>
> ifeq ($(PORTNAME), win32)
>
> $ diff -bu src/makefiles/pgxs.mk.orig src/makefiles/pgxs.mk
> --- src/makefiles/pgxs.mk.orig 2004-07-30 13:26:40.000000000 +0100
> +++ src/makefiles/pgxs.mk 2004-09-10 17:09:15.499748300 +0100
> @@ -63,7 +63,11 @@
>
> ifdef MODULES
> override CFLAGS += $(CFLAGS_SL)
> -SHLIB_LINK += $(BE_DLLLIBS)
> +ifeq ($(PORTNAME), cygwin)
> + SHLIB_LINK += $(BE_DLLLIBS) $(LDFLAGS) $(LIBS) -lpgport
> +else
> + SHLIB_LINK += $(BE_DLLLIBS)
> +endif
> endif
>
> ifdef PG_CPPFLAGS
>
> --
> Reini Urban
> http://xarch.tu-graz.ac.at/home/rurban/
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-10-08 01:55:32 Security implications of config-file-location patch
Previous Message Bruce Momjian 2004-10-08 00:36:33 Re: APR 1.0 released

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Reini Urban 2004-10-08 02:42:57 Re: more dirmod CYGWIN
Previous Message Bruce Momjian 2004-10-08 00:27:21 Re: more dirmod CYGWIN (was: APR 1.0 released)

Browse pgsql-patches by date

  From Date Subject
Next Message Reini Urban 2004-10-08 02:42:57 Re: more dirmod CYGWIN
Previous Message Bruce Momjian 2004-10-08 00:27:21 Re: more dirmod CYGWIN (was: APR 1.0 released)