| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers-win32(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] Re : Win32 binaries test / pg_dump |
| Date: | 2004-07-11 13:19:54 |
| Message-ID: | 200407111319.i6BDJs615002@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers-win32 pgsql-patches |
OK, thanks, adjusted, and I added a comment about control-z handling.
---------------------------------------------------------------------------
Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > + #ifndef WIN32
> > + #define R_TEXTFILE "r"
> > + #else
> > + #define R_TEXTFILE "rb"
> > + #endif
>
> This appears to be redundant with
>
> #if defined(__CYGWIN__) || defined(WIN32)
> #define PG_BINARY O_BINARY
> #define PG_BINARY_R "rb"
> #define PG_BINARY_W "wb"
> #else
> #define PG_BINARY 0
> #define PG_BINARY_R "r"
> #define PG_BINARY_W "w"
> #endif
>
> in c.h.
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-07-11 13:25:20 | Re: Data directory with trailing [back]slash |
| Previous Message | Peter Eisentraut | 2004-07-11 08:10:34 | Re: [PATCHES] Re : Win32 binaries test / pg_dump problem |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-07-11 13:25:20 | Re: Data directory with trailing [back]slash |
| Previous Message | Bruce Momjian | 2004-07-11 13:01:24 | Re: OWNER TO mega patch #2 |