Re: [PATCHES] Re : Win32 binaries test / pg_dump problem

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers-win32(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] Re : Win32 binaries test / pg_dump problem
Date: 2004-07-11 08:10:34
Message-ID: 200407111010.34146.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Bruce Momjian wrote:
> + #ifndef WIN32
> + #define R_TEXTFILE "r"
> + #else
> + #define R_TEXTFILE "rb"
> + #endif

This appears to be redundant with

#if defined(__CYGWIN__) || defined(WIN32)
#define PG_BINARY O_BINARY
#define PG_BINARY_R "rb"
#define PG_BINARY_W "wb"
#else
#define PG_BINARY 0
#define PG_BINARY_R "r"
#define PG_BINARY_W "w"
#endif

in c.h.

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-07-11 13:19:54 Re: [PATCHES] Re : Win32 binaries test / pg_dump
Previous Message Bruce Momjian 2004-07-11 02:57:35 Re: Data directory with trailing [back]slash

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-07-11 13:01:24 Re: OWNER TO mega patch #2
Previous Message Christopher Kings-Lynne 2004-07-11 05:28:22 Re: OWNER TO mega patch #2