Skip site navigation (1) Skip section navigation (2)

Re: Tablespace patch review

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>,pgsql-patches(at)postgresql(dot)org
Subject: Re: Tablespace patch review
Date: 2004-06-20 00:15:46
Message-ID: 200406200015.i5K0FkV13728@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Well, I didn't use tablespaces here so the pg_tablespaces directory is
> > empty, so I can't think of what the tablespace is.
> 
> You look in the pg_tablespace catalog for the row with that OID.
> 
> > Also, are we calling it pg_tablespaces (plural) rather than
> > pg_tablespace?
> 
> I didn't have any particular opinion about that till just now ...
> but now I see that it's a good idea for the pg_tablespaces directory
> (the one that holds all the symlinks) to have a different name from the
> pg_tablespace catalog, especially since the latter has a couple of rows
> that do not correspond to any entries in the former.

If you want something distinct, which I understand, perhaps pg_tblspc.

> I'm not wedded to "pg_tablespaces" as the name in particular, but
> it should not be "pg_tablespace", or we'll suffer the same confusion
> over and over that you just did.

OK.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2004-06-20 01:13:18
Subject: Re: Compiling libpq with VisualC
Previous:From: Gavin SherryDate: 2004-06-20 00:03:41
Subject: Re: [PATCHES] Tablespace patch review

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-06-20 00:55:57
Subject: Re: Tablespace patch review
Previous:From: Gavin SherryDate: 2004-06-20 00:03:41
Subject: Re: [PATCHES] Tablespace patch review

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group