Re: [PATCHES] Tablespace patch review

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [PATCHES] Tablespace patch review
Date: 2004-06-20 00:03:41
Message-ID: Pine.LNX.4.58.0406201002400.24588@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Sat, 19 Jun 2004, Tom Lane wrote:

> [ switching to pghackers for wider comment ]
>
> Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> > By the way, I think that we should deny users the ability to create
> > tablespaces that begin with pg_. Also, the existing ones should be
> > pg_global and pg_default. That way, we have room to move if ever we
> > decide we want more system tablespaces. It also makes it easier to dump
> > non-system tablespaces.
>
> Seems like a reasonable suggestion to me. Any objections?
>
> BTW, another argument for this is that "default" is a reserved word.
> I'd already noticed in testing that CREATE TABLE ... TABLESPACE default
> doesn't work unless you double-quote "default". Calling it pg_default
> would avoid that annoyance.

Great idea. I recognised that default was reserved and was using "default"
in testing. I meant to raise this for discussion when I submitted the
patch. pg_default/pg_global are great.

Gavin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-06-20 00:15:46 Re: Tablespace patch review
Previous Message Tom Lane 2004-06-19 23:24:29 Re: Tablespace patch review

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-06-20 00:15:46 Re: Tablespace patch review
Previous Message Tom Lane 2004-06-19 23:24:29 Re: Tablespace patch review