Re: [PATCHES] Current-stream read for psql's \copy

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Mark Feit <mfeit+postgresql(at)notonthe(dot)net>
Subject: Re: [PATCHES] Current-stream read for psql's \copy
Date: 2004-02-10 17:16:00
Message-ID: 200402101716.i1AHG0q07508@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> I propose we not break existing applications. If we change it the way
> >> you suggest, there'll be no way to do the above.
>
> > But does anyone use such a capability?
>
> What, you're going to remove a feature because you don't think it's
> used? We've been burnt by that approach before.

Yes. We get burnt by it, but we also remove stuff we don't get burnt
by, so it is a value judgement.

> > The program has to generate \. to terminate the input
>
> No it doesn't. EOF will do fine. The source program doesn't
> necessarily have to know anything about COPY, as long as its output is
> in a format COPY can cope with (eg, tab-delimited).

The current behavior seems quite strange and counter-intuitive. We
might break the code for 1-2 people, but we will make it more
predicable for everyone using it.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-02-10 17:23:46 Re: [PATCHES] Current-stream read for psql's \copy
Previous Message Mark Gibson 2004-02-10 16:44:02 Re: [GENERAL] dblink - custom datatypes don't work

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-02-10 17:23:46 Re: [PATCHES] Current-stream read for psql's \copy
Previous Message Mark Gibson 2004-02-10 16:44:02 Re: [GENERAL] dblink - custom datatypes don't work