Re: [PATCHES] Current-stream read for psql's \copy

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Mark Feit <mfeit+postgresql(at)notonthe(dot)net>
Subject: Re: [PATCHES] Current-stream read for psql's \copy
Date: 2004-02-10 17:23:46
Message-ID: 17134.1076433826@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> No it doesn't. EOF will do fine. The source program doesn't
>> necessarily have to know anything about COPY, as long as its output is
>> in a format COPY can cope with (eg, tab-delimited).

> The current behavior seems quite strange and counter-intuitive. We
> might break the code for 1-2 people, but we will make it more
> predicable for everyone using it.

I don't think it's acceptable to simply remove the functionality.
If you wanted to argue about swapping the meanings of STDIN and -
(as defined by the patch) then we could debate about which way is
more consistent and whether it's worth breaking backwards compatibility
to improve consistency. I could probably be talked into supporting
that; as you say, we've done that before. But taking out a useful
behavior that has been there a long time, simply because you've decided
it's unintuitive, is not okay.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-02-10 17:28:47 Re: [PATCHES] Current-stream read for psql's \copy
Previous Message Bruce Momjian 2004-02-10 17:16:00 Re: [PATCHES] Current-stream read for psql's \copy

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-02-10 17:28:47 Re: [PATCHES] Current-stream read for psql's \copy
Previous Message Bruce Momjian 2004-02-10 17:16:00 Re: [PATCHES] Current-stream read for psql's \copy