Re: introduce "default_use_oids"

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: introduce "default_use_oids"
Date: 2003-12-01 23:17:53
Message-ID: 200312012317.hB1NHri13739@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Peter Eisentraut wrote:
> Alvaro Herrera writes:
>
> > On Mon, Dec 01, 2003 at 05:07:40PM -0500, Bruce Momjian wrote:
> >
> > > Neil Conway wrote:
> > > > This patch adds a new GUC var, "default_use_oids", which follows the
> > > > proposal for eventually deprecating OIDs on user tables that I posted
> > > > earlier to pgsql-hackers. pg_dump now always specifies WITH OIDS or
> > > > WITHOUT OIDS when dumping a table. The documentation has been updated.
> > > >
> > > > Comments are welcome.
> >
> > Hum, sorry to be late, but wasn't one of the supposed strenghts of
> > pg_dump supposed to be that you could take a dump and load it on a
> > different RDBMS? I haven't tried it so I don't know if it works, but
> > this patch takes out the ability to do that -- no one else will accept
> > WITH/WITHOUT OIDS, so the dump will have to be modified. Is a switch
> > provided to stop the emission of those modifiers?
>
> I agree with that. By default, WITH/WITHOUT OIDS should not be dumped.

Yes, I see that now:

CREATE TABLE x (
y integer
) WITH OIDS;

We need a solution to this. One idea is to use SET to change the
default_with_oids setting when a table changes characteristics.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2003-12-01 23:28:41 Re: introduce "default_use_oids"
Previous Message Tom Lane 2003-12-01 23:17:16 Re: [PATCH] Re: [pgsql-advocacy] Why READ ONLY transactions?