From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] Reorganization of spinlock defines |
Date: | 2003-09-12 14:46:06 |
Message-ID: | 200309121446.h8CEk6916701@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> "Marc G. Fournier" <scrappy(at)postgresql(dot)org> writes:
> > 'K, now, I know we acquire all our shared_buffers on startup now ... do we
> > do the same with semaphores?
>
> Yes.
>
> > If we do acquire at the start, would it not be trivial to add a message to
> > the startup messages, based on #_of_semaphores != max_connections, that
> > tells ppl that spinlocks aren't being used?
>
> The code already knows whether it's compiled to use spinlocks or not, it
> hardly needs to test that way ;-). I thought you were asking how to
> double-check a system that's live today.
>
> I prefer Bruce's idea of a configure-time warning, myself.
I talked to Marc via IM and I think he now understand the configure
error is best --- it is the most visible way to report the failure.
He was worried about packagers missing the warning, but it is a fatal
error and requires them to enable a flag, so it is pretty clear and
anyone who packages such a binary will know what they are doing.
He is uncomfortable with the port/*.h changes at this point, so it seems
I am going to have to add Itanium/Opteron tests to most of those files.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Jason Tishler | 2003-09-12 14:47:47 | Re: [HACKERS] Win32 native port |
Previous Message | Alessio Bragadini | 2003-09-12 14:45:27 | Re: Beta2 Tag'd and Bundled ... |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-09-12 14:49:32 | Re: [PATCHES] Reorganization of spinlock defines |
Previous Message | Larry Rosenman | 2003-09-12 14:34:57 | Re: __cpu__ defines |