Re: [PATCHES] Reorganization of spinlock defines

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Reorganization of spinlock defines
Date: 2003-09-12 14:33:40
Message-ID: 10919.1063377220@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Marc G. Fournier" <scrappy(at)postgresql(dot)org> writes:
> 'K, now, I know we acquire all our shared_buffers on startup now ... do we
> do the same with semaphores?

Yes.

> If we do acquire at the start, would it not be trivial to add a message to
> the startup messages, based on #_of_semaphores != max_connections, that
> tells ppl that spinlocks aren't being used?

The code already knows whether it's compiled to use spinlocks or not, it
hardly needs to test that way ;-). I thought you were asking how to
double-check a system that's live today.

I prefer Bruce's idea of a configure-time warning, myself.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Larry Rosenman 2003-09-12 14:34:57 Re: __cpu__ defines
Previous Message Andrew Dunstan 2003-09-12 14:33:16 Re: massive quotes?

Browse pgsql-patches by date

  From Date Subject
Next Message Larry Rosenman 2003-09-12 14:34:57 Re: __cpu__ defines
Previous Message Bruce Momjian 2003-09-12 13:59:41 Re: [PATCHES] Reorganization of spinlock defines