| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Gaetano Mendola <mendola(at)bigfoot(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: SetVariable |
| Date: | 2003-08-30 13:58:56 |
| Message-ID: | 200308301358.h7UDwu427952@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Gaetano Mendola wrote:
> "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> > I see other strdup() calls that don't check on a return. Should we deal
> > with those too?
>
> Well strdup obtain the memory for the new string using a malloc
> and normally is a good habit check the return value of a malloc.
Right. My point is that we have lots of other strdup's in the code.
Should we fix those too? Seems we should be consistent.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rod Taylor | 2003-08-30 14:01:58 | Re: Selecting random rows efficiently |
| Previous Message | Rod Taylor | 2003-08-30 13:58:12 | Re: Hardware recommendations to scale to silly load |