From: | "Mendola Gaetano" <mendola(at)bigfoot(dot)com> |
---|---|
To: | <pgsql-hackers(at)postgresql(dot)org> |
Cc: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Subject: | Re: SetVariable |
Date: | 2003-09-01 16:55:19 |
Message-ID: | 003901c370a9$d36bff00$32add6c2@mm.eutelsat.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> Gaetano Mendola wrote:
> > "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> > > I see other strdup() calls that don't check on a return. Should we
deal
> > > with those too?
> >
> > Well strdup obtain the memory for the new string using a malloc
> > and normally is a good habit check the return value of a malloc.
>
> Right. My point is that we have lots of other strdup's in the code.
> Should we fix those too? Seems we should be consistent.
Shall I post the patch for SetVariable ?
I know that this change is not so important but I want to try
on my skin the cycle
seen somethink wrong => send patch => be applyed
Regards
Gaetano Mendola
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-09-01 16:58:40 | Re: array constructor can't construct empty array |
Previous Message | Greg Stark | 2003-09-01 16:49:59 | Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...) |