Re: [BUGS] Bug #928: server_min_messages (log_min_messages

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> * Output controlled by a log_xxx switch should have error level LOG.
>
> > I thought it already did. If not, it certainly should.
>
> I think it probably already does everywhere; I'm just trying to lay out
> the policy in full.

OK.

> > OK. One issue is that I think you should make them all DEBUG1, and move
> > any existing DEBUG1 references to DEBUG2, perhaps moving DEBUG2 up as
> > well. Here are the totals for the various DEBUG* uses:
>
> Something like that. I was planning to take a second look at the debug
> level assignments and make sure they were all rational (ie, some
> relationship between level and usefulness...)

OK, let me renumber them and you can still review them. I did find that
DEBUG4 was used only as a place holder, so I just shifted DEBUG1-3 to
DEBUG 2-4, and made the three debug_ variables to DEBUG1 (debug_pretty_print
doesn't count). I also did trace_notify.

> > I can do the change easily here. It will take just a few minutes. Let
> > me know and I can complete it in an hour.
>
> If you like; doesn't matter to me who does it. I'm busy with a
> different project today.

Patch attached and applied, with doc changes. This deals with filling
the server logs and makes debug_ more agnostic about its output
location.

I am focused on this today, so I might as well do it. :-)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073