Re: psql and readline

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Ross J(dot) Reedstrom" <reedstrm(at)rice(dot)edu>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Peter Mount <peter(at)retep(dot)org(dot)uk>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql and readline
Date: 2003-02-03 12:31:11
Message-ID: 200302031231.h13CVCo18814@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Ross J. Reedstrom wrote:
> On Fri, Jan 10, 2003 at 11:02:55PM +0100, Peter Eisentraut wrote:
> > Ross J. Reedstrom writes:
> >
> > > I already posted a one-line patch to implement this, but it doesn't
> > > seem to hve come through to the list. Here it is inline, instead of as
> > > an attachment:
> >
> > We need this to work without readline as well. (Of course there won't be
> > any history, but it needs to compile.)
>
> <blush> Even after slogging my way through the nesting #ifdefs for readline
> and win32, I forgot! Let's make that a three line patch, then.
>
>
> Index: src/bin/psql/command.c
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/command.c,v
> retrieving revision 1.84
> diff -u -r1.84 command.c
> --- src/bin/psql/command.c 2002/10/23 19:23:56 1.84
> +++ src/bin/psql/command.c 2003/01/10 22:06:07
> @@ -1639,6 +1639,9 @@
> error = true;
> }
>
> +#ifdef USE_READLINE
> + replace_history_entry(where_history(),query_buf->data,NULL);
> +#endif
> fclose(stream);
> }
>
> Ross
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-02-03 12:36:12 Re: targetlist functions part 1 (was [HACKERS] targetlist
Previous Message Bruce Momjian 2003-02-03 12:19:09 Re: [HACKERS] PostgreSQL libraries - PThread Support, but