Re: psql and readline

From: "Ross J(dot) Reedstrom" <reedstrm(at)rice(dot)edu>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: "Ross J(dot) Reedstrom" <reedstrm(at)rice(dot)edu>, Peter Mount <peter(at)retep(dot)org(dot)uk>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql and readline
Date: 2003-01-10 22:07:16
Message-ID: 20030110220716.GA8689@wallace.ece.rice.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 10, 2003 at 11:02:55PM +0100, Peter Eisentraut wrote:
> Ross J. Reedstrom writes:
>
> > I already posted a one-line patch to implement this, but it doesn't
> > seem to hve come through to the list. Here it is inline, instead of as
> > an attachment:
>
> We need this to work without readline as well. (Of course there won't be
> any history, but it needs to compile.)

<blush> Even after slogging my way through the nesting #ifdefs for readline
and win32, I forgot! Let's make that a three line patch, then.

Index: src/bin/psql/command.c
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/command.c,v
retrieving revision 1.84
diff -u -r1.84 command.c
--- src/bin/psql/command.c 2002/10/23 19:23:56 1.84
+++ src/bin/psql/command.c 2003/01/10 22:06:07
@@ -1639,6 +1639,9 @@
error = true;
}

+#ifdef USE_READLINE
+ replace_history_entry(where_history(),query_buf->data,NULL);
+#endif
fclose(stream);
}

Ross

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2003-01-10 22:09:40 Re: v7.3.1 psql against a v7.2.x database ...
Previous Message Peter Eisentraut 2003-01-10 22:02:55 Re: psql and readline