Re: Re: [PATCHES] s_lock.h cleanup

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I believe the formatting problem was that some code had
> > "command;command; : lkjasfd : asldfk" while some had them spread over
> > separate lines, and others used \n\, all very randomly. Now at least
> > they are all consistent and use similar formatting.
>
> And they may all be broken, except for the one(s) you have tested.
> You shouldn't be assuming that a platform that uses gcc necessarily
> also uses gas.
>
> regards, tom lane

I can tell you that they all used __asm__, and all used the colon
terminators for each __asm__ block:

* __asm__ __volatile__(
* "command;"
* "command;"
* "command;"
* : "=r"(_res) return value, in register
* : "r"(lock) argument, 'lock pointer', in register
* : "r0"); inline code uses this register

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026