Re: Re: [PATCHES] s_lock.h cleanup

> Bruce Momjian writes:
>
> > In looking at the VAX ASM problem, I realized that the ASM in s_lock.h
> > is all formatted differently, making it even more confusing. I have
> > applied the following patch to s_lock.h to try and clean it up.
>
> I don't believe in this patch at all. It makes the assumption that all
> assemblers have equally forgiving lexical rules as a certain subset of
> said assemblers. For example, the VAX code does not look at all like the
> one back when it still worked.

I agree the VAX code was changed in the patch, but the VAX person sent
email that he had to add the semicolons to make it work on his platform,
and that the original " \n\" code did compile at all.

I believe the formatting problem was that some code had
"command;command; : lkjasfd : asldfk" while some had them spread over
separate lines, and others used \n\, all very randomly. Now at least
they are all consistent and use similar formatting.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026