Re: [HACKERS] Patch attached...

>
> Attached is a patch for the ONLY inheritance
> functionality...
>
> *) It includes a SET compatibility mode.
> *) The overhead for non-inheritance has
> been cut down to 30 microseconds (on a pc).
> *) It needs an initdb.
>
> Comments welcome.
>

One problem is that you use SearchSysCacheTupleCopy while
SearchSysCacheTuple is more appropriate. You need Copy only when you
are going to be using the cache tuple for an extended period. Looks
like the rest of that particular function is OK.

However, I have received an objection from someone on another issue
related to the patch. There are no documentation changes for that
patch. That includes the SET manual page, and any other place
Inheritance is mentioned. You also need to update
include/catalog/catversion.h because initdb is required.

I will wait for a new patch that has these changes, and any others
mentioned by people. Thanks.

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026