From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Elliot Chance <elliotchance(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
Date: | 2010-12-27 16:54:56 |
Message-ID: | 16894.1293468896@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> src/tools/pginclude/cpluspluscheck
Ah, I'd forgotten that.
> What's missing is to automate this, but it's unclear in what context,
> and perhaps also to what extend this should be a hard requirement.
After a bit of experimentation, I can say that this is better than
Andrew's hack, but it's still a good distance shy of something that
should be automated or treated as a hard requirement. The problem with
it is that it doesn't know anything about inclusion-order restrictions;
and to make matters worse, the actual order in which things are included
will vary for different users, because of the unspecified order in which
'find' will find things.
[ lightbulb ] ... although we could improve that quite a bit if we
processed each .h file separately instead of insisting on smashing
everything into one compilation. Let me go try that.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2010-12-27 17:11:36 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
Previous Message | InterRob | 2010-12-27 16:48:35 | CONSTRAINT does not show when applying a EXCLUDE constraint -- and what about Enterprise Architect? |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2010-12-27 17:11:36 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
Previous Message | Tomas Vondra | 2010-12-27 16:13:03 | estimating # of distinct values |