Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>)

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Elliot Chance <elliotchance(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>)
Date: 2010-12-27 17:11:36
Message-ID: 1293469595-sup-1462@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Excerpts from Tom Lane's message of lun dic 27 13:54:56 -0300 2010:

> [ lightbulb ] ... although we could improve that quite a bit if we
> processed each .h file separately instead of insisting on smashing
> everything into one compilation. Let me go try that.

FWIW I have this patch lingering about that I wrote months ago, to check
for header problems (not C++ stuff, just things like forgetting to
include some necessary header in some other header). Since it needs a
lot of polish (needs to ignore certain headers, and avoid leave
lingering files around), I didn't commit it; and I haven't updated it to
the new Make recursive stuff, either. Maybe someone else knows what to
do with it, though.

*** a/src/include/Makefile
--- b/src/include/Makefile
*************** uninstall:
*** 60,65 ****
--- 60,72 ----
# heuristic...
rm -rf $(addprefix '$(DESTDIR)$(includedir_server)'/, $(SUBDIRS) *.h)

+ check:
+ for dir in $(SUBDIRS); do \
+ for header in `find $(srcdir)/$$dir -type f -name \*.h`; do \
+ echo $$header; \
+ $(CC) $(CFLAGS) $(CPPFLAGS) -include postgres.h -o $$dir/`basename $$header .h`.gch $$header; \
+ done; \
+ done

clean:
rm -f utils/fmgroids.h parser/gram.h utils/probes.h catalog/schemapg.h

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Gauthier, Dave 2010-12-27 17:27:03 Working with v8.3.4 DB using v9.0.1 software
Previous Message Tom Lane 2010-12-27 16:54:56 Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>)

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2010-12-27 17:33:00 Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>)
Previous Message Tom Lane 2010-12-27 16:54:56 Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>)