Re: [PATCH] Move 'long long' check to c.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Move 'long long' check to c.h
Date: 2010-05-23 15:24:17
Message-ID: 14777.1274628257@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> While reviewing bfba40e2c7b3909d3de13bd1b83b7e85fa8dfec2 (mmm, we like
> git diff -p), I noted that c.h is already included by both extern.h
> and ecpg.header through postgres_fe.h. Given this and that we're
> already doing alot of similar #define's there (unlike in those other
> files), I felt c.h was a more appropriate place. Putting it in c.h
> also means we don't have to duplicate that code.

Ugh. Moving that to c.h doesn't render it not junk code. (For one
thing, it will not operate as intended if you haven't previously
#included <limits.h>, which in fact is not included in c.h.)

If we need this we should do it properly with autoconf.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-05-23 15:30:12 Re: mapping object names to role IDs
Previous Message Robert Haas 2010-05-23 15:19:58 Re: mapping object names to role IDs