Re: pg_restore recognizing $-quotes

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgman(at)candle(dot)pha(dot)pa(dot)us>, <pjw(at)rhyme(dot)com(dot)au>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_restore recognizing $-quotes
Date: 2004-08-18 15:31:01
Message-ID: 1453.24.211.141.25.1092843061.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane said:
> "Andrew Dunstan" <andrew(at)dunslane(dot)net> writes:
>> ISTM that a very simple alternative would be to force pg_dump to
>> inhibit dollar quoting for non-text dumps.
>
> I don't want to do that, but I did think that a simpler alternative
> would be to inhibit pg_restore from attempting to parse FUNCTION
> entries. I can't see any strong need for it to do so.
>
> (I haven't had time to review Philip's patch either... but I think
> Bruce was asking whether to put it on the "awaiting review" list...
> definitely yes.)
>

OK. Not sure I understand why, though - the whole point of putting dollar
quoting into pg_dump was to make text dumps nicer to read, I thought (and I
outght to know ;-) ). Once the function is created you have no idea at all
if the body was originally dollar quoted or not.

cheers

andrew

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-08-18 15:33:45 Re: pg_restore recognizing $-quotes
Previous Message Tom Lane 2004-08-18 15:29:30 Re: 7.4.3 & 8.0.0beta1 + Solaris 9: default pg_hba.conf breaks