Re: pgsql: Fix some warnings (probably actual bugs) generated by new GSSAPI

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix some warnings (probably actual bugs) generated by new GSSAPI
Date: 2007-07-12 22:51:09
Message-ID: 13205.1184280669@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Neil Conway <neilc(at)samurai(dot)com> writes:
> On Thu, 2007-07-12 at 17:36 -0300, Tom Lane wrote:
>> Fix some warnings (probably actual bugs) generated by new GSSAPI code
>> when built on a 64-bit machine. Per buildfarm results extracted by Stefan.

> Wouldn't it be more correct to cast size_t to unsigned long, rather than
> unsigned int? Obviously getting GSS tokens larger than an unsigned int
> is unlikely to say the least, so it's probably not a problem in
> practice.

Feel free to change it if you want; I don't think it's an issue as long
as the cast matches the sprintf format.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-07-12 23:10:57 pgsql: Simplify overly-cute array coding to avoid an apparent gcc bug,
Previous Message Tom Lane 2007-07-12 21:27:09 pgsql: Suppress Sun Studio warnings, per Stefan.