Re: pgsql: Fix some warnings (probably actual bugs) generated by new GSSAPI

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix some warnings (probably actual bugs) generated by new GSSAPI
Date: 2007-07-12 21:02:06
Message-ID: 1184274126.27878.29.camel@dell.linuxdev.us.dell.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, 2007-07-12 at 17:36 -0300, Tom Lane wrote:
> Fix some warnings (probably actual bugs) generated by new GSSAPI code
> when built on a 64-bit machine. Per buildfarm results extracted by Stefan.

Wouldn't it be more correct to cast size_t to unsigned long, rather than
unsigned int? Obviously getting GSS tokens larger than an unsigned int
is unlikely to say the least, so it's probably not a problem in
practice.

-Neil

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-07-12 21:04:45 pgsql: Compute max and min int8 values using unsigned arithmetic, in
Previous Message Tom Lane 2007-07-12 20:36:11 pgsql: Fix some warnings (probably actual bugs) generated by new GSSAPI