| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgwin32_safestat weirdness |
| Date: | 2008-04-13 17:25:02 |
| Message-ID: | 12971.1208107502@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Tom - was there a reason it now runs in FRONTEND as well, or was that
> an oversight?
I did do that intentionally because I was worried about "frontend"
code maybe expecting stat to work fully. Like pg_standby for example.
I think the immediate problem is that libpq uses stat() as well,
and depending on your link rules that might mean that safestat
actually has to be bound into libpq.
I would not have a problem with assuming that libpq will never care
about st_size being right, but I'm a lot more nervous about making
that presumption for all FRONTEND code.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-04-13 17:35:19 | Re: pgwin32_safestat weirdness |
| Previous Message | Tom Lane | 2008-04-13 17:20:20 | Re: pgwin32_safestat weirdness |