| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgwin32_safestat weirdness |
| Date: | 2008-04-13 17:20:20 |
| Message-ID: | 11765.1208107220@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I'm confused about the current state of the pgwin32_safestat stuff.
Me too. I tried to fix it a couple of days ago, but seem to have only
moved the problem around :-(
> Cygwin is now building happily, but MinGW is now broken on libpq. It
> looks like libpq now needs dirmod.o or maybe libpgport.a. What I really
> don't understand though is why MinGW is broken but MSVC isn't.
I don't think we should import dirmod.o into libpq; it's too big.
I suggest either
(1) Assume that we don't need "safe" stat for frontend code, and
compile the safestat stuff only when !defined(FRONTEND)
(2) Split safestat into its own file and include that in libpq.
I'm not touching it myself though, since I have no way to test it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-13 17:25:02 | Re: pgwin32_safestat weirdness |
| Previous Message | Magnus Hagander | 2008-04-13 17:16:41 | Re: pgwin32_safestat weirdness |