Re: bug in SignalSomeChildren

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bug in SignalSomeChildren
Date: 2010-12-17 16:07:40
Message-ID: 1292601940-sup-2063@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Tom Lane's message of vie dic 17 12:27:30 -0300 2010:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > I think the attached might be a little tidier. Thoughts?
>
> I'm not really thrilled at the idea of calling
> IsPostmasterChildWalSender for every child whether or not it will have
> any impact on the decision. That involves touching shared memory which
> can be rather expensive (see previous discussions about shared cache
> lines and so forth).

Is it possible to save the "is walsender" flag in the Backend struct?
That would make it possible to solve the problem very easily.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-12-17 16:12:17 Re: bug in SignalSomeChildren
Previous Message Tom Lane 2010-12-17 16:06:04 Re: proposal: FOREACH-IN-ARRAY (probably for 9.2?)