| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | Daniel Verite <daniel(at)manitou-mail(dot)org>, James Inform <james(dot)inform(at)pharmapp(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15892: URGENT: Using an ICU collation in a primary key column breaks ILIKE query |
| Date: | 2019-08-12 17:17:38 |
| Message-ID: | 12522.1565630258@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> writes:
> On 12.08.2019 00:32, Tom Lane wrote:
>> I think Daniel's patch leaves more on the table than it needs to,
>> and I don't like Arthur's patch because it's assuming more than it
>> should about whether it's okay to pass a "char" to u_isalpha().
>> I propose that we do things as attached, instead.
> Yeah, u_isalpha() wasn't such good idea here. BTW Daniel already
> mentioned it above.
> With the patch regression tests pass for me and James test case works
> fine as expected.
Thanks for double-checking! Pushed now.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2019-08-12 18:07:31 | BUG #15950: pg_freespace.avail is 0 |
| Previous Message | Jeff Janes | 2019-08-12 15:11:31 | Re: BUG #15949: pg_basebackup failed(PG-12-Beta3) |