Re: VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types)

From: Neil Conway <neilc(at)samurai(dot)com>
To: Jan Urbański <j(dot)urbanski(at)students(dot)mimuw(dot)edu(dot)pl>
Cc: Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types)
Date: 2008-05-02 21:53:01
Message-ID: 1209765181.22465.11.camel@dell.linuxdev.us.dell.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2008-05-02 at 23:22 +0200, Jan Urbański wrote:
> While looking around vacuum.h (for my GSoC project) I found:
> typedef struct VacAttrStats *VacAttrStatsP;
> and then throughout the code sometimes VacAttrStats *foo is used and
> sometimes VacAttrStatsP bar is used.

Personally I think we should be consistent about this and just use one
form for a given type.

(I don't really care which variant is preferred. Personally, I think
that hiding pointer types inside a typedef is evil and wrong, but it is
relatively common practice in the source...)

-Neil

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-05-02 21:53:31 Re: VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types)
Previous Message Tom Lane 2008-05-02 21:43:26 Re: Protection from SQL injection