AW: AW: AW: Re: tinterval - operator problems on AIX

From: Zeugswetter Andreas SB <ZeugswetterA(at)wien(dot)spardat(dot)at>
To: lockhart(at)fourpalms(dot)org
Cc: Pete Forman <pete(dot)forman(at)westerngeco(dot)com>, "'pgsql-hackers(at)postgresql(dot)org'" <pgsql-hackers(at)postgresql(dot)org>
Subject: AW: AW: AW: Re: tinterval - operator problems on AIX
Date: 2001-01-17 11:23:50
Message-ID: 11C1E6749A55D411A9670001FA6879633681BC@sdexcsrv1.f000.d0188.sd.spardat.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> > > > > Yes, the annoyance is, that localtime works for dates before 1970
> > > > > but mktime doesn't. Best would probably be to assume no DST before
> > > > > 1970 on AIX and IRIX.
> > > >
> > > > That seems like a reasonable answer to me, especially since we have
> > > > other platforms that behave that way. How can we do this --- just
> > > > test for isdst = -1 after the call, and assume that means failure?

Here is a patch that is incremental to the previous patch and makes AIX
not use DST before 1970. The results are now consistent with other
no-DST-before-1970 platforms.

The down side is, that I did not do a configure test, and did not incooperate
IRIX, since I didn't know what define to check.

The correct thing to do instead of the #if defined (_AIX) would be to use
something like #ifdef NO_NEGATIVE_MKTIME and set that with a configure.
Thomas, are you volunteering ?

Andreas

Attachment Content-Type Size
aix_no-DST-before-1970.patch application/octet-stream 2.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2001-01-17 12:44:59 SIGNATURE for int sets (need advise)
Previous Message Zeugswetter Andreas SB 2001-01-17 10:22:12 AW: AW: AW: Re: tinterval - operator problems on AIX