Re: [PATCHES] scan_recycle_buffers

From: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
To: "Mark Kirkwood" <markir(at)paradise(dot)net(dot)nz>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>, <pgsql-patches(at)postgresql(dot)org>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] scan_recycle_buffers
Date: 2007-03-10 22:10:51
Message-ID: 1173564652.3641.439.camel@silverbirch.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Sat, 2007-03-10 at 23:26 +1300, Mark Kirkwood wrote:
> Simon Riggs wrote:
> > New patch enclosed, implementation as you've requested.
> >
> > Not ready to apply yet, but good for testing.
> >
>
> A quick test using the setup for "Buffer cache is not scan resistant"
> thread:
>
> Firstly vanilla 8.3 from 20070310:
>
> Shared Buffers Elapsed vmstat IO rate
> -------------- ------- --------------
> 400MB 101 s 122 MB/s
> 128KB 79 s 155 MB/s [1]
>
> Now apply cycle scan v2:
>
> Shared Buffers Scan_recycle_buffers Elapsed vmstat IO rate
> -------------- -------------------- ------- -------------
> 400MB 0 101 s 122 MB/s
> 400MB 8 78 s 155 MB/s
> 400MB 16 77 s 155 MB/s
> 400MB 32 78 s 155 MB/s
> 400MB 64 82 s 148 MB/s
> 400MB 128 93 s 128 MB/s
>
> Certainly seems to have the desired effect!
>
> Cheers
>
> Mark
>
> [1] I'm not seeing 166 MB/s like previous 8.2.3 data, however 8.3 PGDATA
> is located further toward the end of the disk array - which I suspect is
> limiting the IO rate a little.

That's good news, thanks very much for testing that.

Before we can claim success, we need a few more tests on VACUUM, COPY
and a null test case to show it doesn't effect typical workloads, except
to improve vacuuming. I'll see if we can arrange those at EDB on a
reasonable size system.

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Fuhr 2007-03-10 22:36:43 Re: Race condition in pg_database_size()
Previous Message Pavel Stehule 2007-03-10 21:38:01 Re: what can be wrong? backport plpgpsm to 8.1

Browse pgsql-patches by date

  From Date Subject
Next Message Joachim Wieland 2007-03-10 22:47:20 Re: guc patch: Make variables fall back to default values
Previous Message Peter Eisentraut 2007-03-10 20:35:38 Re: guc patch: Make variables fall back to default values