Re: Uncleared result sets in describeOneTableDetails()

From: Neil Conway <neilc(at)samurai(dot)com>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Uncleared result sets in describeOneTableDetails()
Date: 2006-11-07 13:42:05
Message-ID: 1162906925.25857.20.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2006-11-07 at 17:56 +1100, Brendan Jurd wrote:
> It certainly isn't pretty. It's been a long time since I looked down
> the barrel of a 'goto'.

I don't think there's anything wrong with using "goto" for error
handling in this style. Personally, I think the main stylistic problem
is that the function is 600 lines long: it would be a lot cleaner if
refactored into smaller functions with smaller individual scopes.

-Neil

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Gurjeet Singh 2006-11-07 13:55:59 Found a bug
Previous Message Martijn van Oosterhout 2006-11-07 10:03:42 Re: Index ignored with "is not distinct from", 8.2 beta2