Re: cleanup log_disconnections()

From: Neil Conway <neilc(at)samurai(dot)com>
To: Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: cleanup log_disconnections()
Date: 2005-10-03 08:27:24
Message-ID: 1128328044.10528.21.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Mon, 2005-03-10 at 00:37 -0400, Qingqing Zhou wrote:
> Trivial patch to cleanup log_disconnections() function.

Why does the patch change behavior when

- port->remote_port is the empty string
- or, when end.tv_sec is negative

I'm not adamant that the old behavior is better, but I'd like to see
some justification for why the changes are improvements.

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-10-03 14:36:57 Re: [HACKERS] External Sort timing debug statements
Previous Message Qingqing Zhou 2005-10-03 04:37:38 cleanup log_disconnections()