PG_PAGE_LAYOUT_VERSION - Should be Documented as 3?

From: Matt Miller <mattm(at)epx(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: PG_PAGE_LAYOUT_VERSION - Should be Documented as 3?
Date: 2005-09-01 15:36:12
Message-ID: 1125588973.3636.10.camel@dbamm01-linux
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

doc/src/sgml/storage.sgml says:

"The last 2 bytes of the page header,
<structfield>pd_pagesize_version</structfield>, store both the page size
and a version indicator. Beginning with
<productname>PostgreSQL</productname> 8.0 the version number is 2;
<productname>PostgreSQL</productname> 7.3 and 7.4 used version number 1;
prior releases used version number 0."

But src/include/storage/bufpage.h says:

"/*
* Page layout version number 0 is for pre-7.3 Postgres releases.
* Releases 7.3 and 7.4 use 1, denoting a new HeapTupleHeader layout.
* Release 8.0 changed the HeapTupleHeader layout again.
* Release 8.1 redefined HeapTupleHeader infomask bits.
*/
#define PG_PAGE_LAYOUT_VERSION 3"

So, should the attached be applied?

Attachment Content-Type Size
storage.sgml.patch text/x-patch 1.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergey E. Koposov 2005-09-01 15:44:34 Re: 8.1beta, Subtle bug in COPY in Solaris systems
Previous Message Andrew - Supernews 2005-09-01 15:34:56 Re: TODO item: set proper permissions on non-system schemas