| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: walreceiver is uninterruptible on win32 |
| Date: | 2010-04-05 06:18:06 |
| Message-ID: | v2o3f0b79eb1004042318u3aa4f546l8f2a14b01df07cb1@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 2, 2010 at 11:11 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> More to the point, I'm not sure I like the creation of yet another DLL
> to deal with this. The reason this isn't just exported from the main
> backend is the same reason we created the libpqwalreceiver library I'm
> sure - bt that means we already have one.
>
> How about we just use this same source file, but compile and link it
> directly into both dblink and libpqwalreceiver? That'd leave us with
> one DLL less, making life easier.
ISTM that we cannot compile dblink using USE_PGXS=1, if that DLL doesn't
exist in the installation directory. No?
> As for the code itself, don't we need a CHECK_FOR_INTERRUPTS in there
> for it to be actually useful?
Yes. I'll add a CHECK_FOR_INTERRUPTS in the loop.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2010-04-05 07:00:14 | Re: walreceiver is uninterruptible on win32 |
| Previous Message | TAKATSUKA Haruka | 2010-04-05 06:04:24 | contrib check fail at pgcrypto on Windows Server 2008 64bit 9.0dev (HEAD near alpha5) |