Skip site navigation (1) Skip section navigation (2)

don't allow walsender to consume superuser_reserved_connection slots, or during shutdown

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: don't allow walsender to consume superuser_reserved_connection slots, or during shutdown
Date: 2010-04-22 01:11:50
Message-ID: u2z603c8f071004211811n15d28826z290c1ae6c65fd965@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Apr 21, 2010 at 1:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> ...shouldn't we move the "tests", plural, rather than just the one?
>> It seems right to reject new SR connections during shutdown.
>
> Yeah; you'd also need to adjust both of them to consider am_walsender.
> (IOW, we want to treat SR connections as non-superuser for both tests.)

[ subject changed, recipient list trimmed ]

Here's the fine patch.  The actual code changes are simple and seem to
work as expected, but I struggled a bit with the phrasing of the
messages.  Feel free to suggest improvements.  Also, I wasn't sure if
there was somewhere in the documentation where we discussed the
restriction that only superusers can connect during shutdown.  If
there is such a place, we should update that, too.

...Robert

Attachment: superuser_is_not_enuf.patch
Description: application/octet-stream (3.0 KB)

Responses

pgsql-hackers by date

Next:From: Takahiro ItagakiDate: 2010-04-22 02:00:50
Subject: Re: [GENERAL] trouble with to_char('L')
Previous:From: James William PyeDate: 2010-04-21 22:52:39
Subject: Re: libpq connectoin redirect

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group