Re: Re: bug in pgcrypto 0.3

From: Ian Lance Taylor <ian(at)airs(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Marko Kreen <marko(at)l-t(dot)ee>, Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: bug in pgcrypto 0.3
Date: 2001-05-14 20:15:59
Message-ID: siitj3sn40.fsf@daffy.airs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:

> Applied to 7.1.X and 7.2.

But, but...

> > - return srclen + (srclen / 3) + (srclen / (76 / 2));
> > + return srclen + (srclen + 2 / 3) + (srclen / (76 / 2)) + 2;

(srclen + 2 / 3) is always the same as (srclen).

Perhaps this was meant to be ((srclen + 2) / 3)?

The current code is safe, but weird.

Ian

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Patrick Welche 2001-05-14 20:18:15 Re: 7.2 items
Previous Message Bruce Momjian 2001-05-14 19:44:57 Re: 7.2 items