Re: Win32 timezone matching

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Win32 timezone matching
Date: 2010-04-07 17:10:21
Message-ID: n2o9837222c1004071010zfa84936bj4892269ce18c562b@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 7, 2010 at 7:04 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Apr 7, 2010 at 12:20 PM, Stefan Kaltenbrunner
> <stefan(at)kaltenbrunner(dot)cc> wrote:
>> Tom Lane wrote:
>>>
>>> Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc> writes:
>>>>
>>>> hmm all that code makes me wonder a bit about a more general issue - is
>>>> the "fallback to GMT if we fail to actually make sense of the right imezone
>>>> to use" actually a good idea?
>>>
>>> What alternative are you proposing?  Failing to start the server doesn't
>>> seem like an attractive choice.
>>
>> why not? we do error out in a lot of other cases as well... Personally I
>> find a hard and clear "something is wrong please fix" much more convinient
>> than defaulting to something that is more or less completely arbitrary but
>> well...
>
> While I can understand why someone might want that behavior in some
> cases, in other cases it might be a severe overreaction.

I think the dangerous scenario is if it worked, and then stopped
working. In that case, the database will change it's behavior and it
might go unnoticed. If it's wrong on first install, it'll likely get
noticed..

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-04-07 17:11:00 Re: Streaming replication and a disk full in primary
Previous Message Robert Haas 2010-04-07 17:07:21 Re: Thoughts on pg_hba.conf rejection