Re: Extensions, this time with a patch

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions, this time with a patch
Date: 2010-10-19 13:07:21
Message-ID: m2y69umiuu.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I don't see why. I think the real action item here is to remove =>
> from hstore.

As input, consider that lots of extensions will create types that are
only a shell at the moment of the CREATE TYPE, and for each of those
types you will see the (potentially > 1000 lines long) whole SQL script
dumped on the screen.

In the following script, I've filtered out the scripts, but it's written
out for each NOTICE message that you see:

dim ~/dev/PostgreSQL/postgresql-extension psql -c "create extension citext;" 2>&1 | egrep 'NOTICE|ERROR'
NOTICE: Installing extension 'citext' from '/Users/dim/pgsql/exts/share/contrib/citext.sql', with user data
NOTICE: return type citext is only a shell
NOTICE: argument type citext is only a shell
NOTICE: return type citext is only a shell
NOTICE: argument type citext is only a shell
dim ~/dev/PostgreSQL/postgresql-extension psql -c "create extension cube;" 2>&1 | egrep 'NOTICE|ERROR'
NOTICE: Installing extension 'cube' from '/Users/dim/pgsql/exts/share/contrib/cube.sql', with user data
NOTICE: type "cube" is not yet defined
NOTICE: return type cube is only a shell
NOTICE: return type cube is only a shell
NOTICE: argument type cube is only a shell
dim ~/dev/PostgreSQL/postgresql-extension psql -c "create extension earthdistance;" 2>&1 | egrep 'NOTICE|ERROR'
NOTICE: Installing extension 'earthdistance' from '/Users/dim/pgsql/exts/share/contrib/earthdistance.sql', with user data
dim ~/dev/PostgreSQL/postgresql-extension psql -c "create extension fuzzystrmatch;" 2>&1 | egrep 'NOTICE|ERROR'
NOTICE: Installing extension 'fuzzystrmatch' from '/Users/dim/pgsql/exts/share/contrib/fuzzystrmatch.sql', with user data
dim ~/dev/PostgreSQL/postgresql-extension psql -c "create extension hstore;" 2>&1 | egrep 'NOTICE|ERROR'
NOTICE: Installing extension 'hstore' from '/Users/dim/pgsql/exts/share/contrib/hstore.sql', with user data
NOTICE: return type hstore is only a shell
NOTICE: argument type hstore is only a shell
NOTICE: return type hstore is only a shell
NOTICE: argument type hstore is only a shell
NOTICE: return type ghstore is only a shell
NOTICE: argument type ghstore is only a shell
dim ~/dev/PostgreSQL/postgresql-extension psql -c "create extension isn;" 2>&1 | egrep 'NOTICE|ERROR'
NOTICE: Installing extension 'isn' from '/Users/dim/pgsql/exts/share/contrib/isn.sql', with user data
NOTICE: type "ean13" is not yet defined
NOTICE: argument type ean13 is only a shell
NOTICE: type "isbn13" is not yet defined
NOTICE: argument type isbn13 is only a shell
NOTICE: type "ismn13" is not yet defined
NOTICE: argument type ismn13 is only a shell
NOTICE: type "issn13" is not yet defined
NOTICE: argument type issn13 is only a shell
NOTICE: type "isbn" is not yet defined
NOTICE: argument type isbn is only a shell
NOTICE: type "ismn" is not yet defined
NOTICE: argument type ismn is only a shell
NOTICE: type "issn" is not yet defined
NOTICE: argument type issn is only a shell
NOTICE: type "upc" is not yet defined
NOTICE: argument type upc is only a shell
dim ~/dev/PostgreSQL/postgresql-extension psql -c "create extension ltree;" 2>&1 | egrep 'NOTICE|ERROR'
NOTICE: Installing extension 'ltree' from '/Users/dim/pgsql/exts/share/contrib/ltree.sql', with user data
NOTICE: type "ltree" is not yet defined
NOTICE: argument type ltree is only a shell
NOTICE: type "lquery" is not yet defined
NOTICE: argument type lquery is only a shell
NOTICE: type "ltxtquery" is not yet defined
NOTICE: argument type ltxtquery is only a shell
NOTICE: type "ltree_gist" is not yet defined
NOTICE: argument type ltree_gist is only a shell

Just saying,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

PS: Oh, a repalloc() bug now. Will fix later in the afternoon, \dx or
select * from pg_extensions(); crashes with more than 10 extensions
installed in the v4 patch. That's what I get for doing that on a
Saturday evening.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2010-10-19 13:22:13 Re: leaky views, yet again
Previous Message Robert Haas 2010-10-19 12:51:49 Re: Extensions, this time with a patch