Re: [COMMITTERS] pgsql: Allow external recovery_config_directory

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Date: 2013-03-31 21:20:06
Message-ID: m2wqsnp8qh.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> That's not related to the -R option, the situation with config_file is the
> same with or without it. But yes, if you use config_file option to point
> outside the data directory, the config file won't be backed up. That feels
> intuitive to me, I wouldn't expect it to be. Same with include or

It's a pain when using debian. I think pg_basebackup should copy the
configuration files in the destination directory by default, with an
option to tell it where to store them. Or at least it should issue some
client side warnings when the configuration files are known not to be
included in the backup.

The reason why copying to the destination directory is a good default is
that the debian tool pg_createcluster will then install those
configuration file in the "proper" place in /etc. So that the procedure
would become:

pg_basebackup -D dest ...
pg_createcluster 9.3 main dest
pg_ctlcluster 9.3 main start

And you now have a working standby. Whereas currently you need to add
some extra manual steps to cover the configuration.

> include_dir directives in the config file, as well as hba_file and
> ident_file - I wouldn't expect any of the files that those point to to be
> included in the backup.

Why?

> The filesystem-level backup procedure documented in the user manual, not
> using pg_basebackup, behaves the same.

You can't expect filesystem-level procedures to know that kind of
details, or if you want those to, then use symlinks. On the other hand
the PostgreSQL tools should know to use the pg_settings view.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-03-31 22:35:18 pgsql: Ignore extra subquery outputs in set_subquery_size_estimates().
Previous Message Alvaro Herrera 2013-03-31 21:04:05 pgsql: Translation updates

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-03-31 23:18:45 Re: pkg-config files for libpq and ecpg
Previous Message Dimitri Fontaine 2013-03-31 21:01:41 Re: [PATCH] Exorcise "zero-dimensional" arrays