Re: [HACKERS] Streaming replication document improvements

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-docs(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Streaming replication document improvements
Date: 2010-04-02 06:06:04
Message-ID: k2i3f0b79eb1004012306xdfa88c1cudd77b61368c997ea@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Fri, Apr 2, 2010 at 2:58 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> It's probably also easy to fix so that it doesn't NEED to be documented.
>
> The thing is, when dealing with new features, we reduce our overall
> maintenance burden if we get it right the first time.  Obviously it's
> too late for major changes, but minor adjustments to maintain the POLA
> seem like exactly what we SHOULD be doing right now.

The attached patch implements the Heikki's proposal:

----------
ReservedBackends = superuser_reserved_connections + max_wal_senders
MaxBackends = max_connections + autovacuum_max_workers + max_wal_senders + 1
----------

This change looks like minor adjustments rather than major changes.

I have one question:
In the patch, max_wal_senders is ignored by CheckRequiredParameterValues()
as autovacuum_max_workers is already. Is this OK for HS?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
replication_connections_v1.patch application/octet-stream 9.1 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Devrim GÜNDÜZ 2010-04-02 06:20:32 PDF build issue with 9.0 Alpha5
Previous Message Simon Riggs 2010-04-01 22:55:46 Re: [HACKERS] Streaming replication document improvements

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2010-04-02 06:28:44 Re: Compile fail, alpha5 & gcc 4.3.3 in elog.c
Previous Message Takahiro Itagaki 2010-04-02 05:47:30 Re: Problem of Magic Block in Postgres 8.2