Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

On Mon, Apr 5, 2010 at 4:18 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Mon, 2010-04-05 at 15:58 -0400, Tom Lane wrote:
>> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> >                                     (errmsg("recovery command file \"%s\" specified neither primary_conninfo nor restore_command",
>> > -                                                   RECOVERY_COMMAND_FILE)));
>> > +                                                   RECOVERY_COMMAND_FILE),
>> > +                                    errdetail("The database server will regularly poll the pg_xlog subdirectory to check for files placed there.")));
>>
>> That's not a "detail", as it has nothing to do with details of the error
>> condition.  It might pass muster as a "hint", though I'm not entirely
>> sure what the point is.
>
> The server sits around doing nothing and the point of the message is to
> explain why that is and give a hint as to what might change that
> situation, if anything.

Yeah, I think that's good information to provide. But I have to admit
that I too considered suggesting changing it from errdetail to
errhint, so the fact that Tom had the same thought suggests to me that
that's probably better.

...Robert