| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: do {} while (0) nitpick |
| Date: | 2020-05-06 22:39:01 |
| Message-ID: | fd0af240-2726-0231-7fbb-d17ea45d79f7@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/6/20 6:28 PM, Andrew Dunstan wrote:
> On 5/6/20 3:24 PM, Tom Lane wrote:
>
>> BTW, I looked around and could not find a package-provided ppport.h
>> at all on my Red Hat systems. What package is it in?
>
> perl-Devel-PPPort contains a perl module that will write the file for
> you like this:
>
> perl -MDevel::PPPort -e 'Devel::PPPort::WriteFile();'
FWIW, pgBackRest always shipped with the newest version of ppport.h we
were able to generate. This never caused any issues, but neither did we
have problems that forced us to upgrade.
The documentation seems to encourage this behavior:
Don't direct the users of your module to download Devel::PPPort . They
are most probably no XS writers. Also, don't make ppport.h optional.
Rather, just take the most recent copy of ppport.h that you can find
(e.g. by generating it with the latest Devel::PPPort release from CPAN),
copy it into your project, adjust your project to use it, and distribute
the header along with your module.
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2020-05-06 22:45:14 | Re: BUG #16419: wrong parsing BC year in to_date() function |
| Previous Message | Andrew Dunstan | 2020-05-06 22:28:46 | Re: do {} while (0) nitpick |