Re: [WIP] Reduce alignment requirements on 64-bit systems.

From: "Ryan Bradetich" <rbradetich(at)gmail(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [WIP] Reduce alignment requirements on 64-bit systems.
Date: 2009-01-08 20:39:45
Message-ID: e739902b0901081239q5a711308raf06c8eb807a8f0b@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce,

Thanks for adding this to the TODO.
I am planning on continuing to work on this patch after 8.4 releases.
I know we are in feature freeze and I do not want to sidetrack the
release process.

Thanks!

- Ryan

On Thu, Jan 8, 2009 at 8:41 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> Added to TODO:
>
> Reduce data row alignment requirements on some 64-bit systems
>
> * http://archives.postgresql.org/pgsql-hackers/2008-10/msg00369.php
>
>
> ---------------------------------------------------------------------------
>
> Ryan Bradetich wrote:
>> Hello all,
>>
>> Here is a proof-of-concept patch for reducing the alignment
>> requirement for heap tuples on 64-bit systems.
>> This patch passes the regression tests and a couple of other data sets
>> I have thrown at it.
>>
>> I am hoping to get some early feedback on this patch so I have time to
>> make any corrections, improvements,
>> etc before the November commit-fest deadline.
>>
>> There are two visible savings in the system catalogs using this patch
>> (size was gathered using \S+):
>>
>> Catalog Pre-Patch Size After Patch Size
>>
>> pg_depend 312 kB 296 kB
>> pg_description 160 kB 152 kB
>>
>>
>> One thing I am considering, but I am not sure if it is worth the code
>> uglification, is to wrap the majority of these
>> checks in #ifdefs so they only are used on 64-bit systems. This
>> would completely eliminate the impact for this
>> patch on 32-bit systems, which would not gain any benefit from this patch.
>>
>> Feedback welcome!
>>
>> Thanks,
>>
>> - Ryan
>
> [ Attachment, skipping... ]
>
>>
>> --
>> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgsql-hackers
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-01-08 20:41:22 Re: New patch for Column-level privileges
Previous Message Simon Riggs 2009-01-08 20:37:52 Re: Hot standby, slot ids and stuff